On 2015/06/30 12:11:52, rossberg wrote:
On 2015/06/29 21:30:26, adamk wrote:
> I've confirmed locally that this fixes the performance test. So the only
> question is whether it's the right approach.
>
> I think there's not much point in leaving the flag in, given that there
are
so
> few references to it in code.
>
> As for removing the ability to flag flip this off, that's unfortunate,
but I
> don't think the perf regression is worth the ease-of-disabling. Adding
rossberg
> for his thoughts on this question.
Sounds reasonable to skip the flag toggling in this case. But I'd prefer
to
remove the flag entirely then, instead of leaving it in zombie state.
(That
also
includes moving relevant tests from harmony/ to es6/.)
Removed the flag and moved the test, PTAL.
https://codereview.chromium.org/1215863003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
