LGTM
http://codereview.chromium.org/554062/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/554062/diff/1/2#newcode7506 src/ia32/codegen-ia32.cc:7506: HasArgumentsReversed() ? Indent by one more space. Looks like 3-space indent instead of 4-space indent? http://codereview.chromium.org/554062/diff/1/2#newcode7520 src/ia32/codegen-ia32.cc:7520: HasArgumentsReversed() ? Indent by one more space. http://codereview.chromium.org/554062/diff/1/2#newcode7571 src/ia32/codegen-ia32.cc:7571: if (mode == OVERWRITE_RIGHT) Please uses '{' and '}' when having multi-line if statements. http://codereview.chromium.org/554062 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
