You should probably also update Map::ReconfigureProperty() to handle
SLOW_SLOPPY_ARGUMENTS_ELEMENTS kind the same way as DICTIONARY_ELEMENTS in
order
to leave it in sync with Map::TryUpdate().
Probably all the friend class declarations do not make sense here anymore.
These
implementation classes are not visible outside elements.cc anyway. What
about
making all the protected sections public?
https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc#newcode1735
src/elements.cc:1735: FastHoleyObjectElementsAccessor::DeleteCommon(obj,
key, language_mode);
You can put the implementation of this to the parent if you use
ArgumentsAccessor::DeleteCommon(obj, key, language_mode);
https://codereview.chromium.org/1221713003/diff/20001/src/elements.h
File src/elements.h (right):
https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode24
src/elements.h:24: class SloppyArgumentsElementsAccessor;
These declarations should not be here.
https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode168
src/elements.h:168: ElementsKindTraits<SLOW_SLOPPY_ARGUMENTS_ELEMENTS>
;
These friend declarations should not be here. You can move them to
ElementsAccessorBase<>.
https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc#newcode3721
src/objects.cc:3721: allow_store_transition &=
allow_store_transition = allow_store_transition &&
https://codereview.chromium.org/1221713003/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1221713003/diff/20001/src/objects.h#newcode5705
src/objects.h:5705: return elements_kind() ==
FAST_SLOPPY_ARGUMENTS_ELEMENTS ||
return IsSloppyArgumentsElements(elements_kind());
https://codereview.chromium.org/1221713003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
