[v8-dev] Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot (issue 1218153006 by jochen@chromium.org)

[joc...@chromium.org via codereview.chromium.org]

Reviewers: vogelheim,

Description:
Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot
BUG=none
R=vogelh...@chromium.org
LOG=n

Please review this at https://codereview.chromium.org/1218153006/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1, -1 lines):
  M build/features.gypi


Index: build/features.gypi
diff --git a/build/features.gypi b/build/features.gypi
index  
cb69f880ef96cc7d7f7f94647764aa8ebfd21af9..76bfa22a77cb47f4c48606a91ffb5d8fd8dedf7e  
100644
--- a/build/features.gypi
+++ b/build/features.gypi
@@ -97,7 +97,7 @@
       ['v8_enable_i18n_support==1', {
         'defines': ['V8_I18N_SUPPORT',],
       }],
-      ['v8_use_external_startup_data==1', {
+      ['v8_use_snapshot=="true" and v8_use_external_startup_data==1', {
         'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',],
       }],
       ['dcheck_always_on!=0', {


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.