On 2015/07/01 09:11:49, danno wrote:
I should add tests, but it's unclear if they will be anything other than a
trivial copy of the logic that is in the reducer itself.
You should add tests to verify that the reducer actually makes a change to
the
graph. Otherwise, we might end up breaking it through refactoring.
https://codereview.chromium.org/1220823004/diff/1/src/compiler/context-relaxation.cc
File src/compiler/context-relaxation.cc (right):
https://codereview.chromium.org/1220823004/diff/1/src/compiler/context-relaxation.cc#newcode28
src/compiler/context-relaxation.cc:28: if (!context_is_wired_) {
This is a bit weird, any better ideas?
https://codereview.chromium.org/1220823004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
