Reviewers: rossberg,
Message:
PTAL
Description:
[strong] Add test for strong load involving proxies
Keeping this CL separate in case there are more GC-stress problems.
BUG=v8:3956
LOG=N
Please review this at https://codereview.chromium.org/1217543006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+98, -0 lines):
A test/mjsunit/strong/load-proxy.js
Index: test/mjsunit/strong/load-proxy.js
diff --git a/test/mjsunit/strong/load-proxy.js
b/test/mjsunit/strong/load-proxy.js
new file mode 100644
index
0000000000000000000000000000000000000000..98a3238c4e2c56f2f11c7ba96d9b6f60ca081fa1
--- /dev/null
+++ b/test/mjsunit/strong/load-proxy.js
@@ -0,0 +1,98 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-proxies --strong-mode
+
+// Forwarding proxies adapted from proposal definition
+function handlerMaker1(obj) {
+ return {
+ getPropertyDescriptor: function(name) {
+ var desc;
+ var searchObj = obj;
+ while (desc === undefined && searchObj != null) {
+ desc = Object.getOwnPropertyDescriptor(searchObj, name);
+ searchObj = searchObj.__proto__;
+ }
+ // a trapping proxy's properties must always be configurable
+ if (desc !== undefined) { desc.configurable = true; }
+ return desc;
+ },
+ fix: function() {
+ if (Object.isFrozen(obj)) {
+ var result = {};
+ Object.getOwnPropertyNames(obj).forEach(function(name) {
+ result[name] = Object.getOwnPropertyDescriptor(obj, name);
+ });
+ return result;
+ }
+ // As long as obj is not frozen, the proxy won't allow itself to be
fixed
+ return undefined; // will cause a TypeError to be thrown
+ }
+ };
+}
+function handlerMaker2(obj) {
+ return {
+ get: function(receiver, name) {
+ return obj[name];
+ },
+ fix: function() {
+ if (Object.isFrozen(obj)) {
+ var result = {};
+ Object.getOwnPropertyNames(obj).forEach(function(name) {
+ result[name] = Object.getOwnPropertyDescriptor(obj, name);
+ });
+ return result;
+ }
+ // As long as obj is not frozen, the proxy won't allow itself to be
fixed
+ return undefined; // will cause a TypeError to be thrown
+ }
+ };
+}
+var baseObj = {};
+var proxy1 = Proxy.create(handlerMaker1(baseObj));
+var proxy2 = Proxy.create(handlerMaker2(baseObj));
+var childObj1 = { __proto__: proxy1 };
+var childObj2 = { __proto__: proxy2 };
+var childObjAccessor1 = { set foo(_){}, set "1"(_){}, __proto__: proxy1 };
+var childObjAccessor2 = { set foo(_){}, set "1"(_){}, __proto__: proxy2 };
+
+(function() {
+ "use strong";
+ // TODO(conradw): These asserts are sanity checking V8's proxy
implementation.
+ // Strong mode semantics for ES6 proxies still need to be explored.
+ assertDoesNotThrow(function(){proxy1.foo});
+ assertDoesNotThrow(function(){proxy1[1]});
+ assertDoesNotThrow(function(){proxy2.foo});
+ assertDoesNotThrow(function(){proxy2[1]});
+ assertDoesNotThrow(function(){childObj1.foo});
+ assertDoesNotThrow(function(){childObj1[1]});
+ assertDoesNotThrow(function(){childObj2.foo});
+ assertDoesNotThrow(function(){childObj2[1]});
+ assertThrows(function(){baseObj.foo}, TypeError);
+ assertThrows(function(){baseObj[1]}, TypeError);
+ assertThrows(function(){childObjAccessor1.foo}, TypeError);
+ assertThrows(function(){childObjAccessor1[1]}, TypeError);
+ assertThrows(function(){childObjAccessor2.foo}, TypeError);
+ assertThrows(function(){childObjAccessor2[1]}, TypeError);
+
+ // Once the proxy is no longer trapping, property access should have
strong
+ // semantics.
+ Object.freeze(baseObj);
+
+ Object.freeze(proxy1);
+ assertThrows(function(){proxy1.foo}, TypeError);
+ assertThrows(function(){proxy1[1]}, TypeError);
+ assertThrows(function(){childObj1.foo}, TypeError);
+ assertThrows(function(){childObj1[1]}, TypeError);
+ assertThrows(function(){childObjAccessor1.foo}, TypeError);
+ assertThrows(function(){childObjAccessor1[1]}, TypeError);
+
+ Object.freeze(proxy2);
+ assertThrows(function(){proxy2.foo}, TypeError);
+ assertThrows(function(){proxy2[1]}, TypeError);
+ assertThrows(function(){childObj2.foo}, TypeError);
+ assertThrows(function(){childObj2[1]}, TypeError);
+ assertThrows(function(){childObjAccessor2.foo}, TypeError);
+ assertThrows(function(){childObjAccessor2[1]}, TypeError);
+})();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
