Reviewers: Igor Sheludko,
Message:
ptal
Description:
Remove obsolete GetAccessorPair from ElementsAccessor
BUG=v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1224533003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -54 lines):
M src/elements.h
M src/elements.cc
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index
72c8bfd8cb80455f892c9bf9b9676fb067b1f244..2fb2c973229e27f06e7f06d849d65fbf55cd9f62
100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -650,19 +650,6 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual MaybeHandle<AccessorPair> GetAccessorPair(
- Handle<JSObject> holder, uint32_t key,
- Handle<FixedArrayBase> backing_store) final {
- return ElementsAccessorSubclass::GetAccessorPairImpl(holder, key,
- backing_store);
- }
-
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key,
- Handle<FixedArrayBase> backing_store) {
- return MaybeHandle<AccessorPair>();
- }
-
virtual void SetLength(Handle<JSArray> array, uint32_t length) final {
ElementsAccessorSubclass::SetLengthImpl(array, length,
handle(array->elements()));
@@ -1059,19 +1046,6 @@ class DictionaryElementsAccessor
object->set_elements(*new_dictionary);
}
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key, Handle<FixedArrayBase> store) {
- Handle<SeededNumberDictionary> backing_store =
- Handle<SeededNumberDictionary>::cast(store);
- int entry = backing_store->FindEntry(key);
- if (entry != SeededNumberDictionary::kNotFound &&
- backing_store->DetailsAt(entry).type() == ACCESSOR_CONSTANT &&
- backing_store->ValueAt(entry)->IsAccessorPair()) {
- return handle(AccessorPair::cast(backing_store->ValueAt(entry)));
- }
- return MaybeHandle<AccessorPair>();
- }
-
static bool HasIndexImpl(FixedArrayBase* store, uint32_t index) {
DisallowHeapAllocation no_gc;
SeededNumberDictionary* dict = SeededNumberDictionary::cast(store);
@@ -1547,20 +1521,6 @@ class SloppyArgumentsElementsAccessor
}
}
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key, Handle<FixedArrayBase>
parameters) {
- Handle<FixedArray> parameter_map =
Handle<FixedArray>::cast(parameters);
- Handle<Object> probe(GetParameterMapArg(*parameter_map, key),
- obj->GetIsolate());
- if (!probe->IsTheHole()) {
- return MaybeHandle<AccessorPair>();
- } else {
- // If not aliased, check the arguments.
- Handle<FixedArray>
arguments(FixedArray::cast(parameter_map->get(1)));
- return ArgumentsAccessor::GetAccessorPairImpl(obj, key, arguments);
- }
- }
-
static void SetLengthImpl(Handle<JSArray> array, uint32_t length,
Handle<FixedArrayBase> parameter_map) {
// Sloppy arguments objects are not arrays.
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index
02c15909772fb53fa305b929f477abe7c29eab6d..6fe19559996e695e91c8ba8e8cf38e1f707428c8
100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -54,20 +54,6 @@ class ElementsAccessor {
return Get(holder, key, handle(holder->elements()));
}
- // Returns an element's accessors, or NULL if the element does not exist
or
- // is plain. This method doesn't iterate up the prototype chain. The
caller
- // can optionally pass in the backing store to use for the check, which
must
- // be compatible with the ElementsKind of the ElementsAccessor. If
- // backing_store is NULL, the holder->elements() is used as the backing
store.
- virtual MaybeHandle<AccessorPair> GetAccessorPair(
- Handle<JSObject> holder, uint32_t key,
- Handle<FixedArrayBase> backing_store) = 0;
-
- inline MaybeHandle<AccessorPair> GetAccessorPair(Handle<JSObject> holder,
- uint32_t key) {
- return GetAccessorPair(holder, key, handle(holder->elements()));
- }
-
// Modifies the length data property as specified for JSArrays and
resizes the
// underlying backing store accordingly. The method honors the semantics
of
// changing array sizes as defined in EcmaScript 5.1 15.4.5.2, i.e.
array that
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
