There are some changes missing related to var->IsUnallocated() usages on
non x64
achitectures...
https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h
File src/contexts.h (right):
https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h#newcode561
src/contexts.h:561: void InvalidateGlobalSlots();
On 2015/07/01 09:28:55, Toon Verwaest wrote:
InitializeGlobalSlots
Done.
https://codereview.chromium.org/1218783005/diff/60001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/1218783005/diff/60001/src/globals.h#newcode886
src/globals.h:886: enum class ContextSlotKindFlag { kLocal, kGlobal };
On 2015/07/01 09:28:55, Toon Verwaest wrote:
What about changing Variable::Location to have a GLOBAL or so, rather
than
having CONTEXT that is kLocal or kGlobal?
Done.
https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc#newcode1809
src/objects.cc:1809: if (object->IsGlobalObject()) {
On 2015/07/01 09:28:55, Toon Verwaest wrote:
What case is this needed for?
Add a comment at least.
Done.
https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-debug.cc#newcode691
src/runtime/runtime-debug.cc:691: DCHECK(ContextSlotKindFlag::kLocal ==
slot_kind);
On 2015/07/01 09:28:55, Toon Verwaest wrote:
DCHECK_EQ
This may not be necessary anymore if you separate global from context
in
Variable::Location
Done.
https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):
https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-scopes.cc#newcode652
src/runtime/runtime-scopes.cc:652: result->InvalidateGlobalSlots();
On 2015/07/01 09:28:55, Toon Verwaest wrote:
InitializeGlobalSlots
Done.
https://codereview.chromium.org/1218783005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
