LGTM. I like it.
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc#newcode421
src/deoptimizer.cc:421: code->address() + Code::kHeaderSize,
code->address() + code->Size());
nit: We could use Code::instruction_start() here.
https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):
https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h#oldcode421
src/heap/mark-compact.h:421: // Eliminate all slots that point to the
given invalid_object.
nit: Comment no longer applies.
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
