LGTM!
http://codereview.chromium.org/549147/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/549147/diff/1/2#newcode5276 src/arm/codegen-arm.cc:5276: if (CpuFeatures::IsSupported(VFP3) && Token::MOD != operation) { Since this 'if' is used several times I think it would express the intent clearer to have a bool variable with an explanatory name. eg. float_values_in_vfp_regs. http://codereview.chromium.org/549147/diff/1/2#newcode5426 src/arm/codegen-arm.cc:5426: // Convert smi in r1 to double in d6 Missing full stop. http://codereview.chromium.org/549147 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
