lgtm with a nit and suggestion:
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc
File src/api-natives.cc (right):
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc#newcode150
src/api-natives.cc:150: PropertyKind kind = length == 3 ? kData :
kAccessor;
Instead of writing a length we could pack kind and attributes into
PropertyDetails to save one word per property.
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc#newcode157
src/api-natives.cc:157: if
(TransitionArray::SearchTransition(obj->map(), kind, *name,
Put this call after all the simple checks.
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
