Reviewers: Lasse Reichstein,
Description:
Don't pass the "at start" parameter to native RegExp
As the start index is already passed it is easy to calculate the "at start"
boolean in generated code. Also as direct entry has been implemented this
needs
to be done in generated code anyway, and therefore might as well be moved
to the
generated code for RegExp. The "at start" value is now calcualted as a local
variable on the native RegExp frame based on the value of the start index
argument.
The x64 version have been tested on both Linux and 64-bit Windows Vista.
For ARM I have tested cctest/test-regexp on ARM hardware, but the rest of
the
tests have only been run on the ARM simulator.
Please review this at http://codereview.chromium.org/554078
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/regexp-macro-assembler-arm.h
M src/arm/regexp-macro-assembler-arm.cc
M src/arm/simulator-arm.h
M src/ia32/codegen-ia32.cc
M src/ia32/regexp-macro-assembler-ia32.h
M src/ia32/regexp-macro-assembler-ia32.cc
M src/ia32/simulator-ia32.h
M src/regexp-macro-assembler.h
M src/regexp-macro-assembler.cc
M src/x64/regexp-macro-assembler-x64.h
M src/x64/regexp-macro-assembler-x64.cc
M src/x64/simulator-x64.h
M test/cctest/test-regexp.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
