Nice clean-up!
https://codereview.chromium.org/1218493005/diff/40001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1218493005/diff/40001/src/arm/full-codegen-arm.cc#newcode2130
src/arm/full-codegen-arm.cc:2130: SetExpressionPosition(expr);
Why we don't insert break here?
https://codereview.chromium.org/1218493005/diff/40001/src/arm/full-codegen-arm.cc#newcode2832
src/arm/full-codegen-arm.cc:2832: SetExpressionPosition(expr);
Why we don't insert break here?
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.cc#newcode410
src/full-codegen.cc:410: bool RecordPositions(MacroAssembler* masm, int
pos, bool statement = true) {
Please use enum instead of bool and avoid implicit.
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.cc#newcode783
src/full-codegen.cc:783: SetStatementPosition(stmt, SKIP_BREAK);
Please add a comment that the break is added below.
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.cc#newcode850
src/full-codegen.cc:850: SetStatementPosition(stmt, SKIP_BREAK);
Please add a comment that the break is added below (here and in other
functions too).
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.h
File src/full-codegen.h (right):
https://codereview.chromium.org/1218493005/diff/40001/src/full-codegen.h#newcode665
src/full-codegen.h:665: void SetStatementPosition(Statement* stmt,
Can we make the insert_break explicit in SetStatementPosition and
SetExpressionPosition?
Since they are using opposite defaults call-sites become confusing. Also
SetReturnPosition and SetFunctionPosition do not record slots at all,
but SetExpressionAsStatementPosition does.
SetExpressionAsStatementPosition should be named
SetExpressionAsStatementPositionAndInsertBreak.
https://codereview.chromium.org/1218493005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
