Reviewers: tandrii(chromium), Benedikt Meurer,
Message:
PTAL. This prepares for a CL where binaries with and without patch are
pushed to
different directories.
Description:
[test] Push binaries to separate folders on Android devices.
BUG=chromium:507213
LOG=n
NOTRY=true
[email protected]
Please review this at https://codereview.chromium.org/1213613005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -4 lines):
M tools/run_perf.py
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index
3f73ee6c250693bd48dd978e3b4bedd5eedeac1c..c04e4e77c3c2e70ecf26d46bb7658c396db25a8d
100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -583,12 +583,22 @@ class AndroidPlatform(Platform): # pragma: no cover
bench_rel = "."
bench_abs = suite_dir
- self._PushFile(self.shell_dir, node.binary)
+ self._PushFile(self.shell_dir, node.binary, "bin")
# Push external startup data. Backwards compatible for revisions where
# these files didn't exist.
- self._PushFile(self.shell_dir, "natives_blob.bin",
skip_if_missing=True)
- self._PushFile(self.shell_dir, "snapshot_blob.bin",
skip_if_missing=True)
+ self._PushFile(
+ self.shell_dir,
+ "natives_blob.bin",
+ "bin",
+ skip_if_missing=True,
+ )
+ self._PushFile(
+ self.shell_dir,
+ "snapshot_blob.bin",
+ "bin",
+ skip_if_missing=True,
+ )
if isinstance(node, Runnable):
self._PushFile(bench_abs, node.main, bench_rel)
@@ -598,7 +608,8 @@ class AndroidPlatform(Platform): # pragma: no cover
def Run(self, runnable, count):
cache = cache_control.CacheControl(self.device)
cache.DropRamCaches()
- binary_on_device = AndroidPlatform.DEVICE_DIR + runnable.binary
+ binary_on_device = os.path.join(
+ AndroidPlatform.DEVICE_DIR, "bin", runnable.binary)
cmd = [binary_on_device] + runnable.GetCommandFlags(self.extra_flags)
# Relative path to benchmark directory.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
