LGTM
Thanks for taking care of this. It was on my mind as well.
https://codereview.chromium.org/1220223005/diff/1/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode740
src/frames.cc:740: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset
- 2 * kPointerSize,
Can this be a compile time assert instead?
https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode749
src/frames.cc:749: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset
- 0 * kPointerSize,
same
https://codereview.chromium.org/1220223005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
