lgtm with nits:
https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc#newcode890
src/elements.cc:890: for (int i = 0; i < capacity; i++) {
i -> entry?
https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc#newcode911
src/elements.cc:911: for (int i = 0; i < capacity; i++) {
i -> entry?
https://codereview.chromium.org/1224643004/diff/20001/src/elements.h
File src/elements.h (right):
https://codereview.chromium.org/1224643004/diff/20001/src/elements.h#newcode153
src/elements.h:153: virtual bool HasEntry(FixedArrayBase* backing_store,
uint32_t index) = 0;
This method is also not used.
https://codereview.chromium.org/1224643004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.