https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode727
src/d8.cc:727: // Bounds-check to avoid fatal error in debug mode
I'd just remove this comment: it's not a "bounds-check" in the
traditional sense, it's actually checking for the existence of the
internal field.
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode731
src/d8.cc:731: if (this_value.IsEmpty() || !this_value->IsExternal()) {
Can the second part of this conditional ever fail? I'm guessing not...
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode778
src/d8.cc:778: // Bounds-check to avoid fatal error in debug mode
Ditto, comment seems off.
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode782
src/d8.cc:782: if (this_value.IsEmpty() || !this_value->IsExternal()) {
Ditto, I don't think IsExternal can fail now
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode806
src/d8.cc:806: // Bounds-check to avoid fatal error in debug mode
And here...
https://codereview.chromium.org/1214053004/diff/60001/src/d8.cc#newcode810
src/d8.cc:810: if (this_value.IsEmpty() || !this_value->IsExternal()) {
And here
https://codereview.chromium.org/1214053004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
