Reviewers: Mads Ager, Description: Removing redundant stub for runtime native calls.
Please review this at http://codereview.chromium.org/543207 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/macro-assembler-ia32.cc Index: src/ia32/macro-assembler-ia32.cc =================================================================== --- src/ia32/macro-assembler-ia32.cc (revision 3710) +++ src/ia32/macro-assembler-ia32.cc (working copy) @@ -1098,10 +1098,14 @@ return; } - Runtime::FunctionId function_id = - static_cast<Runtime::FunctionId>(f->stub_id); - RuntimeStub stub(function_id, num_arguments); - CallStub(&stub); + // TODO(1236192): Most runtime routines don't need the number of + // arguments passed in because it is constant. At some point we + // should remove this need and make the runtime routine entry code + // smarter. + Set(eax, Immediate(num_arguments)); + mov(ebx, Immediate(ExternalReference(f))); + CEntryStub ces(1); + call(ces.GetCode(), RelocInfo::CODE_TARGET); } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
