LGTM
http://codereview.chromium.org/556020/diff/1001/1002 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/556020/diff/1001/1002#newcode4867 src/arm/codegen-arm.cc:4867: __ push(lr); You can move this push(lr) and the corresponding pop(lr) into the if since it is only necessary when there is a call. Similarly below. http://codereview.chromium.org/556020/diff/1001/1002#newcode4915 src/arm/codegen-arm.cc:4915: // Load the double from lhs, tagged HeapNumber r1, to d7. You should do this first since the vldr has a delay that you can use to do the other instructions. http://codereview.chromium.org/556020/diff/1001/1002#newcode5153 src/arm/codegen-arm.cc:5153: // __ vmov(d6, r0, r1); Commented out code. http://codereview.chromium.org/556020 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
