LGTM with comment.
https://codereview.chromium.org/1215463012/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):
https://codereview.chromium.org/1215463012/diff/1/src/runtime/runtime-scopes.cc#newcode234
src/runtime/runtime-scopes.cc:234: if (isolate->has_pending_exception())
return isolate->heap()->exception();
This looks hacky. I.e. we should have returned a MaybeHandle.
But then again this is proxy, so I guess I'm fine with this. Can we
first check for holder.is_null() first like we do below?
https://codereview.chromium.org/1215463012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
