LGTM modulo a couple comments. Nice to see this coming together!
https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h#newcode102
src/code-stubs.h:102: V(MathFloor) \
Why is this now listed as an IC handler stub?
https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js#newcode796
src/runtime.js:796: %_FixedArraySet(tv, ((i|0)+1)|0, 1);
It would be cool if expressions like ((i|0)+1)|0 could live in a macro,
especially as we create more of these excellent turbofan code stubs.
https://codereview.chromium.org/1225943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
