Looks good.
The try bots seem to have caught a reproducible issue -- maybe that's
related to
the bug you're hunting?
Also, as discussed, since this converts DCHECKs to CHECKs and hence might
crash
when the old code would have continued running (albeit incorrectly), we
shouldn't land this before the upcoming branch point.
https://codereview.chromium.org/1219533003/diff/40001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/1219533003/diff/40001/src/compiler.cc#newcode216
src/compiler.cc:216: CHECK(feedback_vector_.is_null());
This looks wrong. The condition right above explicitly allows cases
where feedback_vector_ is not null.
https://codereview.chromium.org/1219533003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
