Reviewers: jochen,
Message:
PTAL, thanks.
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
File src/base/smart-pointers.h (right):
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#newcode90
src/base/smart-pointers.h:90: namespace internal {
I kept this in namespace v8::internal to avoid ugly namespaces every
where it is used (much like smart_ptr isn't in namespace base::).
https://codereview.chromium.org/1221433021/diff/1/test/unittests/test-utils.cc
File test/unittests/test-utils.cc (right):
https://codereview.chromium.org/1221433021/diff/1/test/unittests/test-utils.cc#newcode78
test/unittests/test-utils.cc:78: :
rng_(GetRandomSeedFromFlag(::v8::internal::FLAG_random_seed)) {}
Not sure why this change ended up being necessary, but I get a compile
error here after moving SmartPointer otherwise.
Description:
Move SmartPointer to base.
Please review this at https://codereview.chromium.org/1221433021/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+47, -175 lines):
M BUILD.gn
M src/ast.h
M src/background-parsing-task.h
A + src/base/smart-pointers.h
M src/d8.h
M src/heap-profiler.h
M src/objects.h
D src/smart-pointers.h
M test/cctest/test-api.cc
M test/cctest/test-api-interceptors.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-lockers.cc
M test/cctest/test-migrations.cc
M test/unittests/test-utils.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
