LGTM
https://codereview.chromium.org/1213623020/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1213623020/diff/1/src/deoptimizer.cc#newcode1235
src/deoptimizer.cc:1235: value =
reinterpret_cast<intptr_t>(isolate_->heap()->undefined_value());
On 2015/07/08 15:20:36, Michael Starzinger wrote:
On 2015/07/08 15:14:28, arv wrote:
> Maybe I'm missing something here. Why is this set to undefined.
Shouldn't we
use
> the original constructor?
We do not yet support inlining of constructor calls where the callee
uses the
new.target variable, so nobody will look at this field. Also, even if
we would
support such inlining, this field would only be looked at if the
deoptimization
actually happens in the prologue of the callee, before the new.target
variable
is assigned.
But I am happy to leave a TODO behind in that regard if you feel we
need one.
No need.
https://codereview.chromium.org/1213623020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
