Reviewers: Michael Starzinger, jarin, Benedikt Meurer,
Message:
Created Revert of [turbofan] Optimize string "length" property access based
on
types.
Description:
Revert of [turbofan] Optimize string "length" property access based on
types.
(patchset #2 id:20001 of https://codereview.chromium.org/1216593003/)
Reason for revert:
Causes crash when running benchmarks/octane/regexp.js on ARM:
http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp
Original issue's description:
[turbofan] Optimize string "length" property access based on types.
Optimize string "length" property access based on static type
information if possible, but also optimistically optimize the access
based on type feedback from the LoadIC.
[email protected]
Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40
Cr-Commit-Position: refs/heads/master@{#29543}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Please review this at https://codereview.chromium.org/1224083002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -279 lines):
M BUILD.gn
M src/compiler/access-builder.cc
D src/compiler/js-type-feedback-lowering.h
D src/compiler/js-type-feedback-lowering.cc
M src/compiler/js-typed-lowering.h
M src/compiler/js-typed-lowering.cc
M src/compiler/pipeline.cc
D test/mjsunit/compiler/string-length.js
M test/unittests/compiler/js-typed-lowering-unittest.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
