lgtm
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h#newcode3769
src/preparser.h:3769: if (is_strict(language_mode()) ||
allow_harmony_sloppy()) {
A tangent, but it looks like CheckConflictingVarDeclarations is
implemented only in the parser, not the preparser, so the errors aren't
quite as early as we'd optimally like. Any particular reason for this?
It looks like the preparser maintains the whole scope thing anyway.
https://codereview.chromium.org/1226103002/diff/40001/test/mjsunit/harmony/block-conflicts-sloppy.js
File test/mjsunit/harmony/block-conflicts-sloppy.js (right):
https://codereview.chromium.org/1226103002/diff/40001/test/mjsunit/harmony/block-conflicts-sloppy.js#newcode62
test/mjsunit/harmony/block-conflicts-sloppy.js:62: //
TestAll('Conflict', 'eval("' + s + '");');
I don't see why these tests wouldn't make sense. Wouldn't there be a
conflict in the new eval-driven block scope, even in sloppy mode?
https://codereview.chromium.org/1226103002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
