Reviewers: Michael Starzinger,
Description:
Allow deferred handle dereference in EmitLoadRegister to retrieve number.
[email protected]
BUG=chromium:507977
LOG=N
Please review this at https://codereview.chromium.org/1230653004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M src/arm/lithium-codegen-arm.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/lithium-codegen-mips64.cc
M src/ppc/lithium-codegen-ppc.cc
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index
747730b3f5132e24e5b87ecb73a7d9e989b93b4d..c56206a9ea899a80dfec0fa8b0c66d2a0dd449b4
100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -427,6 +427,7 @@ Register LCodeGen::EmitLoadRegister(LOperand* op,
Register scratch) {
Handle<Object> literal = constant->handle(isolate());
Representation r = chunk_->LookupLiteralRepresentation(const_op);
if (r.IsInteger32()) {
+ AllowDeferredHandleDereference get_number;
DCHECK(literal->IsNumber());
__ mov(scratch, Operand(static_cast<int32_t>(literal->Number())));
} else if (r.IsDouble()) {
Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc
b/src/mips/lithium-codegen-mips.cc
index
5c26001ef0feb9b64d6e454567908f6c353e2b6f..b1166c7c647bbc10c5f7897c43e0df668e281d3a
100644
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -424,6 +424,7 @@ Register LCodeGen::EmitLoadRegister(LOperand* op,
Register scratch) {
Handle<Object> literal = constant->handle(isolate());
Representation r = chunk_->LookupLiteralRepresentation(const_op);
if (r.IsInteger32()) {
+ AllowDeferredHandleDereference get_number;
DCHECK(literal->IsNumber());
__ li(scratch, Operand(static_cast<int32_t>(literal->Number())));
} else if (r.IsSmi()) {
Index: src/mips64/lithium-codegen-mips64.cc
diff --git a/src/mips64/lithium-codegen-mips64.cc
b/src/mips64/lithium-codegen-mips64.cc
index
1273d856cc59c4dbeb9f05ddb93dacf95a4f71ad..c860606bbd40b62e43c1bed6b62646f0094cf873
100644
--- a/src/mips64/lithium-codegen-mips64.cc
+++ b/src/mips64/lithium-codegen-mips64.cc
@@ -407,6 +407,7 @@ Register LCodeGen::EmitLoadRegister(LOperand* op,
Register scratch) {
Handle<Object> literal = constant->handle(isolate());
Representation r = chunk_->LookupLiteralRepresentation(const_op);
if (r.IsInteger32()) {
+ AllowDeferredHandleDereference get_number;
DCHECK(literal->IsNumber());
__ li(scratch, Operand(static_cast<int32_t>(literal->Number())));
} else if (r.IsSmi()) {
Index: src/ppc/lithium-codegen-ppc.cc
diff --git a/src/ppc/lithium-codegen-ppc.cc b/src/ppc/lithium-codegen-ppc.cc
index
8f4cd4637af8e1c61b1be0cecb172b07ade298e0..85438f47b3f799de884c3337568abdeb7d57135e
100644
--- a/src/ppc/lithium-codegen-ppc.cc
+++ b/src/ppc/lithium-codegen-ppc.cc
@@ -417,6 +417,7 @@ Register LCodeGen::EmitLoadRegister(LOperand* op,
Register scratch) {
Handle<Object> literal = constant->handle(isolate());
Representation r = chunk_->LookupLiteralRepresentation(const_op);
if (r.IsInteger32()) {
+ AllowDeferredHandleDereference get_number;
DCHECK(literal->IsNumber());
__ LoadIntLiteral(scratch, static_cast<int32_t>(literal->Number()));
} else if (r.IsDouble()) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
