Reviewers: rmcilroy,
Message:
Hey Ross,
This is an obvious one that I discovered while hunting the constant pool
bug.
Please take a look.
Thanks,
Benedikt
Description:
[arm] Remove unused jump_elimination_allowed parameter to
Assembler::branch_offset().
That parameter is just confusing and completely unused.
Please review this at https://codereview.chromium.org/1228763003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -9 lines):
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index
74c682a47f60799b4fecc7cbf56a7f99bddb0dce..de49bb185f106aefe58a0db91b4fb835ecf75b92
100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -1308,7 +1308,7 @@ void Assembler::addrmod5(Instr instr, CRegister crd,
const MemOperand& x) {
}
-int Assembler::branch_offset(Label* L, bool jump_elimination_allowed) {
+int Assembler::branch_offset(Label* L) {
int target_pos;
if (L->is_bound()) {
target_pos = L->pos();
Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index
879021df3b9755b7a954ed66e6a498f4b189467b..9140864a2ce21de3337e70bbf394459644e2d774
100644
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -700,7 +700,7 @@ class Assembler : public AssemblerBase {
// Returns the branch offset to the given label from the current code
position
// Links the label to the current position if it is still unbound
// Manages the jump elimination optimization if the second parameter is
true.
- int branch_offset(Label* L, bool jump_elimination_allowed);
+ int branch_offset(Label* L);
// Returns true if the given pc address is the start of a constant pool
load
// instruction sequence.
@@ -806,13 +806,11 @@ class Assembler : public AssemblerBase {
void bx(Register target, Condition cond = al); // v5 and above, plus v4t
// Convenience branch instructions using labels
- void b(Label* L, Condition cond = al) {
- b(branch_offset(L, cond == al), cond);
- }
- void b(Condition cond, Label* L) { b(branch_offset(L, cond == al),
cond); }
- void bl(Label* L, Condition cond = al) { bl(branch_offset(L, false),
cond); }
- void bl(Condition cond, Label* L) { bl(branch_offset(L, false), cond); }
- void blx(Label* L) { blx(branch_offset(L, false)); } // v5 and above
+ void b(Label* L, Condition cond = al) { b(branch_offset(L), cond); }
+ void b(Condition cond, Label* L) { b(L, cond); }
+ void bl(Label* L, Condition cond = al) { bl(branch_offset(L), cond); }
+ void bl(Condition cond, Label* L) { bl(branch_offset(L), cond); }
+ void blx(Label* L) { blx(branch_offset(L)); } // v5 and above
// Data-processing instructions
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
