LGTM
http://codereview.chromium.org/555131/diff/10/3004 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/555131/diff/10/3004#newcode6323 src/x64/codegen-x64.cc:6323: // Load rcx with zero. We use this either for the final shift or All this stuff could probably be reimplemented in a simpler way loading the whole double into a 64 bit register. On the other hand almost all 64 bit processors have SSE3 so it's hardly worth it. http://codereview.chromium.org/555131/diff/10/3004#newcode7493 src/x64/codegen-x64.cc:7493: __ Cmp(rdx, Factory::undefined_value()); You should use CompareRoot here. It's a tiny bit faster and somewhat more compact. That applies to the other uses of Cmp too. http://codereview.chromium.org/555131 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
