Comment #4 on issue 4292 by [email protected]: ARM constant pool
emission seems to be wrong sometimes
https://code.google.com/p/v8/issues/detail?id=4292#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/d05538827e32ebfed5297653266d65c11e438148
commit d05538827e32ebfed5297653266d65c11e438148
Author: bmeurer <[email protected]>
Date: Thu Jul 09 09:33:17 2015
[arm] Fix missing CheckBuffer for branches.
The b, bl and blx methods that take labels basically ignore the constant
pool check and just block the constant pool for the next instruction.
This way a long enough sequence of those instructions will block can
potentially block the constant pool emission for too long.
BUG=v8:4292
LOG=y
[email protected]
Review URL: https://codereview.chromium.org/1223093004
Cr-Commit-Position: refs/heads/master@{#29550}
[modify]
http://crrev.com/d05538827e32ebfed5297653266d65c11e438148/src/arm/assembler-arm.cc
[modify]
http://crrev.com/d05538827e32ebfed5297653266d65c11e438148/src/arm/assembler-arm.h
[modify]
http://crrev.com/d05538827e32ebfed5297653266d65c11e438148/test/cctest/test-assembler-arm.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
