I foolishly rebased. In the third patch set I only touched src/debug.cc,
src/debug.h and src/assembler.cc
https://codereview.chromium.org/1222093007/diff/40001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/1222093007/diff/40001/src/assembler.cc#newcode737
src/assembler.cc:737: if (SetMode(rmode)) return
AdvanceReadDebugBreakSlotData();
On 2015/07/08 11:53:33, ulan wrote:
Did you mean
if (SetMode(rmode)) return;
AdvanceReadDebugBreakSlotData()
here?
actually no. if SetMode returns true, we want to read the slot data, and
then return. I changed this to be less ambiguous.
https://codereview.chromium.org/1222093007/diff/40001/src/debug.h
File src/debug.h (right):
https://codereview.chromium.org/1222093007/diff/40001/src/debug.h#newcode88
src/debug.h:88: inline int CallArgc() const {
On 2015/07/08 11:53:33, ulan wrote:
Please use CallArgCount() or CallArgumentsCount()
Done.
https://codereview.chromium.org/1222093007/diff/40001/src/debug.h#newcode128
src/debug.h:128: static const int kNonCallArgc = -2;
On 2015/07/08 11:53:33, ulan wrote:
Please use the same constants here and in assembler.h
Removed. They are not actually necessary anymore.
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
