On 2015/07/09 10:03:46, Benedikt Meurer wrote:
On 2015/07/09 09:59:51, rmcilroy wrote:
> On 2015/07/09 09:52:34, Benedikt Meurer wrote:
>
> As discussed offline, let's add a DCHECK in BlockConstPoolFor to ensure
it's
> never called from within a BlockConstPoolScope. I'll try and think of a
way
to
> repo your bug...
As mentioned by Rodolph offline, BlockConstPoolFor is safe to call within
a
BlockConstPoolScope.
The issue is really the call to branch_offset from within CheckConstPool,
it
seems.
lgtm, thanks!
https://codereview.chromium.org/1224243002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
