Revision: 3719 Author: [email protected] Date: Wed Jan 27 05:53:19 2010 Log: Changed JSObject::DefineGetterSetter to also set the right attributes when an existing accessor is redefined (a configurable accessor can potentially be redefined as a non-configurable (i.e., DONT_DELETE)).
Review URL: http://codereview.chromium.org/556040 http://code.google.com/p/v8/source/detail?r=3719 Modified: /branches/bleeding_edge/src/objects.cc ======================================= --- /branches/bleeding_edge/src/objects.cc Tue Jan 12 15:42:36 2010 +++ /branches/bleeding_edge/src/objects.cc Wed Jan 27 05:53:19 2010 @@ -2839,7 +2839,11 @@ if (result.IsReadOnly()) return Heap::undefined_value(); if (result.type() == CALLBACKS) { Object* obj = result.GetCallbackObject(); - if (obj->IsFixedArray()) return obj; + if (obj->IsFixedArray()) { + PropertyDetails details = PropertyDetails(attributes, CALLBACKS); + SetNormalizedProperty(name, obj, details); + return obj; + } } } } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
