A few comments, but as I say below, I think verwaest@ is the right reviewer
for
this approach.
The simpler approach of treating IsAccessCheckNeeded() as undefined seems
like
nearly as good a solution, though: the only thing it disallows in practice
is
making Window and Location objects ConcatSpreadable, something I'd hope no
one
would ever try to do.
https://codereview.chromium.org/1230793002/diff/40001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1230793002/diff/40001/src/objects.h#newcode1219
src/objects.h:1219: MUST_USE_RESULT static inline MaybeHandle<Object>
GetPropertyOrFallbackValue(
I'd wait for Toon's review before making more changes, but this needs a
better name if it's the approach we want to take. This name says nothing
to me about access checks.
https://codereview.chromium.org/1230793002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1230793002/diff/40001/test/cctest/test-api.cc#newcode21910
test/cctest/test-api.cc:21910: Local<Value> result2 =
CompileRun("[].concat([global, global], protected)");
On 2015/07/09 at 14:49:41, caitp wrote:
This is probably not doing what I want it to do
I would like context 1 to attempt to pass an array from context 2 to
ArrayConcat() --- and the spreading should occur because the value is an
Array, and regardless of whether @@isConcatSpreadable is set to
undefined or not.
The API is sort of confusing so I'm not totally sure how to simulate
that.
Is the idea just to check that the check is doing IsJSArray() instead of
instanceof? That seems like a separate concern from the security check
test case going on here.
https://codereview.chromium.org/1230793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
