LGTM (with comments addressed)
http://codereview.chromium.org/549158/diff/6001/7002 File src/compiler.cc (right): http://codereview.chromium.org/549158/diff/6001/7002#newcode97 src/compiler.cc:97: ASSERT(!FLAG_always_full_compiler || !FLAG_always_fast_compiler); 'Classic' mode would be "--nofull-compiler --nofast-compiler" then, right? http://codereview.chromium.org/549158/diff/6001/7002#newcode110 src/compiler.cc:110: (FLAG_fast_compiler) && !is_run_once) { Misplaced parenthesis? Should it be: } else if (FLAG_always_fast_compiler || (FLAG_fast_compiler && !is_run_once)) { http://codereview.chromium.org/549158/diff/6001/7008 File src/fast-codegen.cc (right): http://codereview.chromium.org/549158/diff/6001/7008#newcode78 src/fast-codegen.cc:78: if (decls->length() > 0) { VisitDeclarations is not called yet, I'd leave the body emtpy or UNREACHABLE(). Or implement it as in the FullCodeGenSyntaxChecker and put in an unconditional BAILOUT in VisitDeclaration. http://codereview.chromium.org/549158 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
