http://codereview.chromium.org/549158/diff/6001/7002
File src/compiler.cc (right):
http://codereview.chromium.org/549158/diff/6001/7002#newcode97
src/compiler.cc:97: ASSERT(!FLAG_always_full_compiler ||
!FLAG_always_fast_compiler);
On 2010/01/27 14:47:11, Erik Corry wrote:
I think CHECK would be more appropriate.
OK.
http://codereview.chromium.org/549158/diff/6001/7002#newcode110
src/compiler.cc:110: (FLAG_fast_compiler) && !is_run_once) {
On 2010/01/27 14:30:01, fschneider wrote:
Misplaced parenthesis? Should it be:
} else if (FLAG_always_fast_compiler ||
(FLAG_fast_compiler && !is_run_once)) {
Yes, thank you.
http://codereview.chromium.org/549158/diff/6001/7008
File src/fast-codegen.cc (right):
http://codereview.chromium.org/549158/diff/6001/7008#newcode78
src/fast-codegen.cc:78: if (decls->length() > 0) {
On 2010/01/27 14:30:01, fschneider wrote:
VisitDeclarations is not called yet, I'd leave the body emtpy or
UNREACHABLE().
Or implement it as in the FullCodeGenSyntaxChecker and put in an
unconditional
BAILOUT in VisitDeclaration.
OK. I originally had it that way so I'll just change it back.
http://codereview.chromium.org/549158
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
