Reviewers: ,

Message:
This problem has been already reported as
https://code.google.com/p/v8/issues/detail?id=4280#c2
and fixed by https://codereview.chromium.org/1230473006

So this can be closed as duplicate.

Description:
Fix max number of allocatable registers in
DwVfpRegister::AllocationIndexToString
for armv7 which has 16 double word VFP registers
(but called for 32 from ArchDefaultRegisterConfiguration).

BUG=v8:4286

Please review this at https://codereview.chromium.org/1230593007/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1, -1 lines):
  M src/arm/assembler-arm.cc


Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index 96bdf79facedebfecd39c57e2cda0668f1f7c006..fda8781e5ad4a87c0d99f4371fe16838d75c0a08 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -216,7 +216,7 @@ void CpuFeatures::PrintFeatures() {
 // Implementation of DwVfpRegister

 const char* DwVfpRegister::AllocationIndexToString(int index) {
-  DCHECK(index >= 0 && index < NumAllocatableRegisters());
+  DCHECK(index >= 0 && index < kMaxNumAllocatableRegisters);
   DCHECK(kScratchDoubleReg.code() - kDoubleRegZero.code() ==
          kNumReservedRegisters - 1);
   if (index >= kDoubleRegZero.code()) index += kNumReservedRegisters;


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to