Please update all the other calls to JSReceiver::SetElement() and
JSObject::SetElement() with calls to Object::SetElement.
lgtm once the comments are addressed.
https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc#newcode62
src/lookup.cc:62: Handle<JSReceiver> LookupIterator::GetRoot() {
I think it is better to keep GetRoot() static given that you call it
during object construction. You just need an additional parameter "bool
is_element".
https://codereview.chromium.org/1221303019/diff/50001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1221303019/diff/50001/test/cctest/test-heap.cc#newcode794
test/cctest/test-heap.cc:794: JSReceiver::SetElement(isolate, array, 0,
name, SLOPPY).Check();
Object::SetElement(...) here and below.
https://codereview.chromium.org/1221303019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
