https://codereview.chromium.org/1226143003/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode1703
src/d8.cc:1703: case STOPPED:
Why do we want to retry when STOPPED?
Actually, I am even confused why we are trying to go through the
TERMINATING state in WaitForThread. Why (instead of calling Terminate)
don't you CAS RUNNING->JOINING?
It would be helpful if you could describe what was wrong with the
original state machine.
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode1708
src/d8.cc:1708: case JOINING:
Is not this only called when the shell finishes, so there should not be
anyone else joining?
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode2187
src/d8.cc:2187: char* p = new char[length];
How about using std::vector<char> here, instead of the naked pointer?
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode2268
src/d8.cc:2268: // Now that all workers are terminated, we can re-enable
Worker creation.
I know this has not be introduced by this CL, but why do we want to
re-enable worker creation? At this point, the process is about to die,
no?
https://codereview.chromium.org/1226143003/diff/1/src/d8.h
File src/d8.h (right):
https://codereview.chromium.org/1226143003/diff/1/src/d8.h#newcode261
src/d8.h:261: enum State { IDLE, RUNNING, TERMINATING, STOPPED, JOINING,
JOINED };
Could we have some descriptions of what the states mean?
https://codereview.chromium.org/1226143003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
