LGTM.
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc
File src/assembler.cc (left):
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc#oldcode287
src/assembler.cc:287: // pc-jump (variable length):
Should we preserve the description of the variable length encoding? It's
still used for PC_JUMP, correct?
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc#newcode761
src/assembler.cc:761: case PC_JUMP:
Should this really be inreachable?
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc#newcode864
src/assembler.cc:864: case PC_JUMP:
Likewise.
https://codereview.chromium.org/1230183002/diff/1/src/assembler.h
File src/assembler.h (right):
https://codereview.chromium.org/1230183002/diff/1/src/assembler.h#newcode352
src/assembler.h:352: // The minimum size of a comment is equal to three
bytes for the extra tagged
nit: s/three/two/
https://codereview.chromium.org/1230183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
