lgtm with nits:
https://codereview.chromium.org/1232463005/diff/1/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1232463005/diff/1/src/elements.cc#newcode1552
src/elements.cc:1552: return
ArgumentsAccessor::GetDetailsImpl(arguments, entry);
While you are here, please call this like
ArgumentsAccessor::GetDetailsImpl(arguments, entry - length);
to be uniform with other places.
https://codereview.chromium.org/1232463005/diff/1/src/elements.cc#newcode1689
src/elements.cc:1689:
FastHoleyObjectElementsAccessor::SetImpl(arguments, index, *value);
For better readability, please convert index to entry before passing it
to SetImpl() even it's a no-op.
https://codereview.chromium.org/1232463005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
