On 2015/07/10 08:35:38, jochen wrote:
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
File src/base/smart-pointers.h (right):
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#newcode90
src/base/smart-pointers.h:90: namespace internal {
On 2015/07/08 at 14:30:58, rmcilroy wrote:
> I kept this in namespace v8::internal to avoid ugly namespaces every
where
it
is used (much like smart_ptr isn't in namespace base::).
hum, i'd rather have it in base. scoped_ptr isn't e.g. in namespace
content
either.
Ok, done. PTAL, thanks.
https://codereview.chromium.org/1221433021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
