Reviewers: dstence, michael_dawson, Yang,
Description:
PPC: Debugger: record reloc info for debug break slot immediate before the
slot.
Port 0a19e44925301b9c0a554bbec5e3fb5a6cd09efa
Original commit message:
If we do it too early, we might get a constant pool between the reloc
info
and the actual slot.
[email protected], [email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1232123006/
Base URL: https://chromium.googlesource.com/v8/v8.git@patch7
Affected files (+4, -1 lines):
M src/ppc/debug-ppc.cc
Index: src/ppc/debug-ppc.cc
diff --git a/src/ppc/debug-ppc.cc b/src/ppc/debug-ppc.cc
index
cdb88b20b25ae0a21bf39ac8cafec253c66cdca0..054dd2cc2d7a047ab21cf4751b658726a04b7cdd
100644
--- a/src/ppc/debug-ppc.cc
+++ b/src/ppc/debug-ppc.cc
@@ -138,12 +138,15 @@ void
DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
}
-void DebugCodegen::GenerateSlot(MacroAssembler* masm) {
+void DebugCodegen::GenerateSlot(MacroAssembler* masm,
+ DebugCodegen::SlotLocation location,
+ int call_argc) {
// Generate enough nop's to make space for a call instruction. Avoid
emitting
// the trampoline pool in the debug break slot code.
Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm);
Label check_codesize;
__ bind(&check_codesize);
+ RecordRelocInfo(masm, location, call_argc);
for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
__ nop(MacroAssembler::DEBUG_BREAK_NOP);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.