Feedback addressed, landing
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode1194
src/snapshot/serialize.cc:1194: case kNativesStringResource: {
On 2015/07/10 at 08:18:57, Yang wrote:
no need for the scoping brackets anymore.
Done
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode1440
src/snapshot/serialize.cc:1440: // The bootstrap already snapshot has a
code-stub context, when serializing
On 2015/07/10 at 08:18:57, Yang wrote:
weird sentence...
Done
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode2192
src/snapshot/serialize.cc:2192: kNativesStringResource,
"NativesStringResource",
On 2015/07/10 at 08:18:57, Yang wrote:
Those string arguments are really just for documentation. sink_->Put
doesn't actually use them. (We used to use them for when we add printf
debugging to sink_->Put). So you could just omit them as arguments and
use "StringResource" and "StringResourceEnd" in the method itself.
Done
https://codereview.chromium.org/1213203007/diff/320001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/src/code-stubs.cc#newcode471
src/code-stubs.cc:471: isolate,
Handle<JSObject>(isolate->heap()->code_stub_exports_object()),
On 2015/07/10 at 13:26:30, Michael Starzinger wrote:
nit: Just use isolate->factory()->code_stub_exports_object() here.
Done
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-api.cc#newcode11694
test/cctest/test-api.cc:11694: CheckSurvivingGlobalObjectsCount(1);
On 2015/07/10 at 13:26:30, Michael Starzinger wrote:
Can we move this off-by-one into the GetGlobalObjectsCount() helper,
together with a comment explaining why we are always seeing one global
object too many?
Done
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-debug.cc#newcode7344
test/cctest/test-debug.cc:7344: CHECK_EQ(2, CountNativeContexts());
On 2015/07/10 at 13:26:30, Michael Starzinger wrote:
Same comment as in test-api.cc applies for CountNativeContexts() as
well.
Done.
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap-profiler.cc#newcode99
test/cctest/test-heap-profiler.cc:99: // The 0th-child is (GC Roots),
1st is the user root.
On 2015/07/10 at 13:26:30, Michael Starzinger wrote:
nit: Comment is outdated.
Done
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap.cc#newcode1562
test/cctest/test-heap.cc:1562: CHECK_EQ(1, CountNativeContexts());
On 2015/07/10 at 13:26:30, Michael Starzinger wrote:
Same comment as in test-api.cc applies for CountNativeContexts() as
well.
Done
https://codereview.chromium.org/1213203007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
