On 2015/07/13 08:33:50, Jakob wrote:
LGTM if it works.
https://codereview.chromium.org/1234443003/diff/1/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/1234443003/diff/1/build/standalone.gypi#newcode361
build/standalone.gypi:361: 'conditions': [
nit: indentation (one more space).
Done.
Good question whether it works. It already looks as if it worked now:
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_ninja_rel/builds/1
But I want to take the warning
https://code.google.com/p/chromium/issues/detail?id=508921#c6 seriously and
add
a patch on the build side first.
The configuration is basically a dummy, as our configurations are
bitness-independent. Whatever target_arch is set to is authoritative. I
don't
know what would be compiled with target_arch=ia32 using Release_x64, but we
won't do that.
https://codereview.chromium.org/1234443003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
