Reviewers: Søren Gjesse, Mads Ager, Description: Try to workaround tail call elimination which removes all the parameters that I really want to see for diagnosing issue 555.
Please review this at http://codereview.chromium.org/554112 SVN Base: http://v8.googlecode.com/svn/branches/experimental/issue555/ Affected files: M src/objects.cc Index: src/objects.cc =================================================================== --- src/objects.cc (revision 3727) +++ src/objects.cc (working copy) @@ -8320,8 +8320,15 @@ Object* function, bool runs_in_inner_context, bool runs_in_outer_context) { - // Kill the virtual machine. + // Try to avoid calling out to another function for breaking here to + // avoid tail call elimination when using the Microsoft Visual + // Studio compiler which removes the parameters from the stack + // trace. +#if defined(_MSC_VER) + __ asm int3; +#else OS::Abort(); +#endif } } } // namespace v8::internal -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
