[v8-dev] Our JavaScriptFrame::function_slot_object is arch independent. (issue 1235893002 by [email protected])

Mon, 13 Jul 2015 04:32:49 -0700 

Reviewers: Benedikt Meurer,

Description:
Our JavaScriptFrame::function_slot_object is arch independent.

[email protected]

Please review this at https://codereview.chromium.org/1235893002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+6, -48 lines):
  M src/arm/frames-arm.h
  M src/arm64/frames-arm64.h
  M src/frames-inl.h
  M src/ia32/frames-ia32.h
  M src/mips/frames-mips.h
  M src/mips64/frames-mips64.h
  M src/ppc/frames-ppc.h
  M src/x64/frames-x64.h
  M src/x87/frames-x87.h


Index: src/arm/frames-arm.h
diff --git a/src/arm/frames-arm.h b/src/arm/frames-arm.h
index db6a9e52e05809edfd3c0e5acaa784b966bbef72..dcba34f0175067d450d3b7c6eb3f4a06d5c617d4 100644 
--- a/src/arm/frames-arm.h
+++ b/src/arm/frames-arm.h
@@ -128,12 +128,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif  // V8_ARM_FRAMES_ARM_H_
Index: src/arm64/frames-arm64.h
diff --git a/src/arm64/frames-arm64.h b/src/arm64/frames-arm64.h
index 963dc3e025e7ad0f9e355e49abeb4f8d46f99da1..9e6551783da9b4cd1edeae10abb159a5f91c0ec6 100644 
--- a/src/arm64/frames-arm64.h
+++ b/src/arm64/frames-arm64.h
@@ -63,12 +63,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif  // V8_ARM64_FRAMES_ARM64_H_
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index 650d6f9725f4ab30df736034093d6b426bbc2fb9..e69bcd90338dd8f56fe7c87c5c5f0194f499ff38 100644 
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -217,6 +217,12 @@ inline JSFunction* JavaScriptFrame::function() const {
 }


+inline Object* JavaScriptFrame::function_slot_object() const {
+  const int offset = JavaScriptFrameConstants::kFunctionOffset;
+  return Memory::Object_at(fp() + offset);
+}
+
+
 inline StubFrame::StubFrame(StackFrameIteratorBase* iterator)
     : StandardFrame(iterator) {
 }
Index: src/ia32/frames-ia32.h
diff --git a/src/ia32/frames-ia32.h b/src/ia32/frames-ia32.h
index fddace732eb36f333dee160c750d6b39a75c099c..1d200c04b0e726eb5fbb8d9c3f45f67bd4ae7240 100644 
--- a/src/ia32/frames-ia32.h
+++ b/src/ia32/frames-ia32.h
@@ -79,12 +79,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif  // V8_IA32_FRAMES_IA32_H_
Index: src/mips/frames-mips.h
diff --git a/src/mips/frames-mips.h b/src/mips/frames-mips.h
index f0b734db1c69dfb4a52355c5db005d518a5f2fa4..0452ece222bba6253f6c431865b4dbe13a30fa79 100644 
--- a/src/mips/frames-mips.h
+++ b/src/mips/frames-mips.h
@@ -169,12 +169,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif
Index: src/mips64/frames-mips64.h
diff --git a/src/mips64/frames-mips64.h b/src/mips64/frames-mips64.h
index 4434a98b7fb7d0ac42baea8aef76ff09372d2706..9b6d32627526975a696dee2e1174388ce8061e69 100644 
--- a/src/mips64/frames-mips64.h
+++ b/src/mips64/frames-mips64.h
@@ -169,12 +169,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif
Index: src/ppc/frames-ppc.h
diff --git a/src/ppc/frames-ppc.h b/src/ppc/frames-ppc.h
index 0357731b4ba3563abd04ddb7e34eab82cdcaa104..16e86db65f2aae541e65eea667a2813e9b6ba5a7 100644 
--- a/src/ppc/frames-ppc.h
+++ b/src/ppc/frames-ppc.h
@@ -148,12 +148,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 }
 }  // namespace v8::internal

Index: src/x64/frames-x64.h
diff --git a/src/x64/frames-x64.h b/src/x64/frames-x64.h
index 0719baffbf9dadee9bb76bc644de1cf802c8df70..1d9cf1ec13ad76f096549d61e44fb3f5cf86612b 100644 
--- a/src/x64/frames-x64.h
+++ b/src/x64/frames-x64.h
@@ -71,12 +71,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif  // V8_X64_FRAMES_X64_H_
Index: src/x87/frames-x87.h
diff --git a/src/x87/frames-x87.h b/src/x87/frames-x87.h
index 78209258d62c9c5c2441709c971384f0a43a2c22..c9e75e83ea60a4d06d9a9681a77e9da42efa3f0b 100644 
--- a/src/x87/frames-x87.h
+++ b/src/x87/frames-x87.h
@@ -79,12 +79,6 @@ class JavaScriptFrameConstants : public AllStatic {
 };


-inline Object* JavaScriptFrame::function_slot_object() const {
-  const int offset = JavaScriptFrameConstants::kFunctionOffset;
-  return Memory::Object_at(fp() + offset);
-}
-
-
 } }  // namespace v8::internal

 #endif  // V8_X87_FRAMES_X87_H_


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to