Now INSIDE_TYPEOF is used really from Typeof.
https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode738
src/ic/ic.cc:738: if (it.IsFound() || typeof_mode() == INSIDE_TYPEOF) {
On 2015/07/10 15:41:31, Toon Verwaest wrote:
typeof_mode() == INSIDE_TYPEOF is not the same as
!IsUndeclaredGlobal(object).
You basically want
it.IsFound() || typeof_mode() == INSIDE_TYPEOF ||
!object->IsGlobalObject(). If
there was no failing test (seems unlikely?) please add one.
Done.
https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode749
src/ic/ic.cc:749: } else if (typeof_mode() == INSIDE_TYPEOF) {
On 2015/07/10 15:41:31, Toon Verwaest wrote:
Same here.
Done.
https://codereview.chromium.org/1227893005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
