LGTM, thanks!
https://codereview.chromium.org/1227163011/diff/40001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/1227163011/diff/40001/src/arm/builtins-arm.cc#newcode497
src/arm/builtins-arm.cc:497: __ ldr(r3, MemOperand(sp, 0 *
kPointerSize));
On 2015/07/13 13:05:52, Michael Starzinger wrote:
Acknowledged. Hmm, I thought having this explicit would increase
readability.
Also we already do this in Generate_NotifyDeoptimizedHelper and a
couple of
asserts. But I don't feel strongly about this.
Ok, I'm not really worried either way.
https://codereview.chromium.org/1227163011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
