STATIC_ASSERT comments apply to all architectures.
https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc#newcode3800
src/arm/macro-assembler-arm.cc:3800: cmp(current,
Operand(factory->null_value()));
why not CompareRoot()?
https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc#newcode3810
src/arm/macro-assembler-arm.cc:3810: cmp(r4, Operand(JS_OBJECT_TYPE));
s/r4/scratch1/
Why don't tests catch this?
https://codereview.chromium.org/1228063004/diff/2/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/ia32/macro-assembler-ia32.cc#newcode3193
src/ia32/macro-assembler-ia32.cc:3193: DCHECK(JS_PROXY_TYPE <
JS_OBJECT_TYPE);
nit: STATIC_ASSERT
https://codereview.chromium.org/1228063004/diff/2/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/ic/arm/ic-arm.cc#newcode666
src/ic/arm/ic-arm.cc:666: __ b(lt, &slow);
s/lt/lo/ for unsigned comparison
https://codereview.chromium.org/1228063004/diff/2/src/ic/arm64/ic-arm64.cc
File src/ic/arm64/ic-arm64.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/ic/arm64/ic-arm64.cc#newcode665
src/ic/arm64/ic-arm64.cc:665: __ B(lt, &slow);
s/lt/lo/ for unsigned comparison
https://codereview.chromium.org/1228063004/diff/2/src/ic/ia32/ic-ia32.cc
File src/ic/ia32/ic-ia32.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/ic/ia32/ic-ia32.cc#newcode544
src/ic/ia32/ic-ia32.cc:544: DCHECK(JS_VALUE_TYPE < JS_OBJECT_TYPE);
STATIC_ASSERT
https://codereview.chromium.org/1228063004/diff/2/src/ic/mips/ic-mips.cc
File src/ic/mips/ic-mips.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/ic/mips/ic-mips.cc#newcode663
src/ic/mips/ic-mips.cc:663: __ Branch(&slow, lt, t0,
Operand(JS_OBJECT_TYPE));
s/lt/lo/ for unsigned comparison
https://codereview.chromium.org/1228063004/diff/2/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/1228063004/diff/2/src/mips/macro-assembler-mips.cc#newcode6002
src/mips/macro-assembler-mips.cc:6002: Branch(found, lt, scratch1,
Operand(JS_OBJECT_TYPE));
s/lt/lo/ for unsigned comparison
https://codereview.chromium.org/1228063004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
